chore(crwa): remove React prop-types package
#9206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
force-pushed
the
ds-crwa/remove-prop-types
branch
from
1356a1d
to
0bae522
Compare
Tobbe
pushed a commit
to Tobbe/redwood
that referenced
this pull request
Dec 22, 2023
TypeScript has long been well established; React prop-types is a vestigial feature. The package hasn't been updated in ~2 years (https://www.npmjs.com/package/prop-types) and the legacy React docs recommend moving off it: https://legacy.reactjs.org/docs/typechecking-with-proptypes.html. <img width="913" alt="image" src="https://github.com/redwoodjs/redwood/assets/32992335/acfe01fc-6248-4fc6-a47d-3340b417a637"> There are a few things about this PR that are technically breaking. `prop-types` isn't a huge package so I don't think it's important this goes into the next minor or anything; it can just be scheduled for the next major.
Tobbe
pushed a commit
that referenced
this pull request
Dec 22, 2023
TypeScript has long been well established; React prop-types is a vestigial feature. The package hasn't been updated in ~2 years (https://www.npmjs.com/package/prop-types) and the legacy React docs recommend moving off it: https://legacy.reactjs.org/docs/typechecking-with-proptypes.html. <img width="913" alt="image" src="https://github.com/redwoodjs/redwood/assets/32992335/acfe01fc-6248-4fc6-a47d-3340b417a637"> There are a few things about this PR that are technically breaking. `prop-types` isn't a huge package so I don't think it's important this goes into the next minor or anything; it can just be scheduled for the next major.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript has long been well established; React prop-types is a vestigial feature. The package hasn't been updated in ~2 years (https://www.npmjs.com/package/prop-types) and the legacy React docs recommend moving off it: https://legacy.reactjs.org/docs/typechecking-with-proptypes.html.
There are a few things about this PR that are technically breaking.
prop-typesisn't a huge package so I don't think it's important this goes into the next minor or anything; it can just be scheduled for the next major.