Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli): Setup from npm package #9215

Merged
merged 2 commits into from
Sep 20, 2023
Merged

docs(cli): Setup from npm package #9215

merged 2 commits into from
Sep 20, 2023

Conversation

Josh-Walker-GM
Copy link
Collaborator

Docs
This is designed to cover the new yarn rw setup package <npm-package> command.

@Josh-Walker-GM Josh-Walker-GM added the release:docs This PR only updates docs label Sep 20, 2023
@Josh-Walker-GM Josh-Walker-GM added this to the v6.3.0 milestone Sep 20, 2023
@Josh-Walker-GM
Copy link
Collaborator Author

@jtoar I wasn't sure if I should have gone into any more depth on the workings of the command - I felt that might just be excessive. I also was not sure if the final sentence should be in some sort of coloured box to highlight it's importance?

Happy to update with any suggestions you provide.

Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Josh-Walker-GM, suggesting a few edits. Going to commit these and merge so that I can get this into the next release.

docs/docs/cli-commands.md Outdated Show resolved Hide resolved
docs/docs/cli-commands.md Outdated Show resolved Hide resolved
docs/docs/cli-commands.md Outdated Show resolved Hide resolved
docs/docs/cli-commands.md Outdated Show resolved Hide resolved
docs/docs/cli-commands.md Outdated Show resolved Hide resolved
docs/docs/cli-commands.md Outdated Show resolved Hide resolved
docs/docs/cli-commands.md Outdated Show resolved Hide resolved
@jtoar jtoar merged commit 6abe206 into main Sep 20, 2023
10 of 11 checks passed
@jtoar jtoar deleted the jgmw-docs/cli-setup-package branch September 20, 2023 23:33
jtoar added a commit that referenced this pull request Sep 20, 2023
**Docs**
This is designed to cover the new `yarn rw setup package <npm-package>`
command.

---------

Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:docs This PR only updates docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants