telemetry: Insight into gitpod adoption #9365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@Josh-Walker-GM it's very reasonable + helpful to add this metric. And agree with your method for determining if the dev env is GitPod — simple and efficient.
My quick reaction is that we should make this more extensible because we won't just want to know if it's GitPod (e.g. Codespaces). What if:
- metric is "Dev Environment",
devEnvfor short - I'm fine with a default like "unknown"; we don't need to check for local dev env...
- we can add more checks, i.e. "is Codespaces?", when we add support / starter repos
What do you think?
Josh-Walker-GM
commented
Nov 2, 2023
jtoar
pushed a commit
that referenced
this pull request
Nov 6, 2023
**Changes** 1. Checks for environment variables that starts with `GITPOD_` and records whether any are found. This should allow us to gain an insight into gitpod usage. I guess there could be false positive if non-gitpod machines have env vars with `GITPOD_` but we can likely assume this to be highly unlikely?
jtoar
pushed a commit
that referenced
this pull request
Nov 8, 2023
**Changes** 1. Checks for environment variables that starts with `GITPOD_` and records whether any are found. This should allow us to gain an insight into gitpod usage. I guess there could be false positive if non-gitpod machines have env vars with `GITPOD_` but we can likely assume this to be highly unlikely?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
GITPOD_and records whether any are found. This should allow us to gain an insight into gitpod usage. I guess there could be false positive if non-gitpod machines have env vars withGITPOD_but we can likely assume this to be highly unlikely?