Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9316/update mantine setup #9388

Merged
merged 6 commits into from
Nov 27, 2023
Merged

9316/update mantine setup #9388

merged 6 commits into from
Nov 27, 2023

Conversation

bnn1
Copy link
Contributor

@bnn1 bnn1 commented Nov 7, 2023 •
edited by Tobbe
Loading

Include mantine css and postcss files during mantine setup

There's a bit overlap with #9309 PR: both PRs change the same file - storybook mantine template.

Fixes #9316

@bnn1 bnn1 mentioned this pull request Nov 8, 2023
Merged
@jtoar jtoar self-assigned this Nov 15, 2023
jtoar
jtoar suggested changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bnn1! Just got around to reviewing this one. I ran it and it worked locally. Still need to read mantine's docs so I have context, but I noticed a few things so pointing those out for now:

.gitignore Show resolved Hide resolved
__fixtures__/test-project/package.json Outdated Show resolved Hide resolved
packages/cli/src/commands/setup/ui/libraries/mantine.js Outdated Show resolved Hide resolved
packages/cli/src/commands/setup/ui/templates/mantine-postcss.config.js.template Outdated Show resolved Hide resolved
@bnn1 bnn1 requested a review from jtoar November 16, 2023 11:37
@bnn1
Copy link
Contributor Author

bnn1 commented Nov 23, 2023

Hey @jtoar, I've made requested changes

@dac09 dac09 added this to the next-release milestone Nov 27, 2023
@dac09 dac09 added the release:fix This PR is a fix label Nov 27, 2023
@dac09 dac09 added the fixture-ok Override the test project fixture check label Nov 27, 2023
dac09
dac09 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@dac09 dac09 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @bnn1!

Taking over from @jtoar here. Everything looking good!

I've noticed the docs for Redwood setup on the mantine website is out of date though! (Since v6 we no longer use webpack by default).

@dac09 dac09 enabled auto-merge (squash) November 27, 2023 07:37
@dac09 dac09 assigned dac09 and unassigned jtoar Nov 27, 2023
@dac09 dac09 merged commit 1f04ce7 into redwoodjs:main Nov 27, 2023
34 of 35 checks passed
@Tobbe Tobbe mentioned this pull request Nov 28, 2023
Closed
1 task
jtoar pushed a commit that referenced this pull request Nov 29, 2023
@bnn1 @dac09 @jtoar
9316/update mantine setup (#9388)
f1e44e6 
Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
@jtoar jtoar modified the milestones: next-release-patch, v6.4.1 Nov 29, 2023
jtoar pushed a commit that referenced this pull request Nov 29, 2023
@bnn1 @dac09 @jtoar
9316/update mantine setup (#9388)
a82f6cd 
Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
@jtoar jtoar modified the milestones: v6.4.1, next-release-patch Nov 29, 2023
jtoar pushed a commit that referenced this pull request Nov 29, 2023
@bnn1 @dac09 @jtoar
9316/update mantine setup (#9388)
2c5cac2 
Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
dac09 added a commit that referenced this pull request Jan 22, 2024
@dac09
Merge branch 'main' of github.com:redwoodjs/redwood into try/setupSce…
e0104f6 
…nario-multiple-tests

* 'main' of github.com:redwoodjs/redwood: (21 commits)
  fix(deps): update dependency @whatwg-node/server to v0.9.18 (#9602)
  fix(deps): update dependency @apollo/client to v3.8.8 (#9600)
  chore: update yarn.lock
  chore(deps): update dependency @playwright/test to v1.40.1 (#9599)
  chore(deps): update dependency @supabase/supabase-js to v2.39.0 (#9603)
  fix(deps): update dependency @clerk/clerk-sdk-node to v4.12.22 (#9601)
  chore(deps): update dependency @clerk/clerk-react to v4.28.1 (#9598)
  fix(deps): update storybook monorepo to v7.6.2 (#9597)
  RSC: Generate a route manifest (#9592)
  chore(private-set): Wrap profile page in <PrivateSet> instead of Private (#9575)
  add documentation on mocking useParams in component test (#9284)
  Update Typescript to 5.3.2 (#9589)
  RSC: Refactor build process (#9588)
  fix(crwa): clarify docs to avoid issues in yarn modern installs (#9579)
  fix: Prevent `rw graphiql setup` from breaking with encryptSession error (#9582)
  fix: Remove "god code" typos from auth READMEs (#9583)
  Experimental Dockerfile: Fix typo in setup command (#9577)
  fix(streaming-ssr): Fixes running the streaming server using rw serve (#9558)
  9316/update mantine setup (#9388)
  chore: clean up `RouteParams` type test structure (#9573)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dac09 dac09 dac09 approved these changes

@jtoar jtoar Awaiting requested review from jtoar

Assignees

@dac09 dac09

Labels
fixture-ok Override the test project fixture check release:fix This PR is a fix
Projects
None yet
Milestone
v6.4.1
Development

Successfully merging this pull request may close these issues.

[Bug?]: Mantine setup yarn rw setup ui mantine is not updated to work with Mantine V7
3 participants
@bnn1 @dac09 @jtoar