Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test project fixture with Trusted Documents changes #9560

Closed
wants to merge 1 commit into from
Closed

Update test project fixture with Trusted Documents changes #9560

wants to merge 1 commit into from

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Nov 20, 2023

Related to this recent PR: #9416

@Tobbe Tobbe added the release:chore This PR is a chore (means nothing for users) label Nov 20, 2023
@Tobbe Tobbe added this to the next-release milestone Nov 20, 2023
dthyresson
dthyresson reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@dthyresson dthyresson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tobbe It was my intention to remove the default inclusion of possibleTypes both in the CRWA and test fixture. Instead, I would like to only dynamically import possibleType and configure the Apollo cache with it if one enables fragments via the graphql tromp config.

However, it looks like the CRWA still has this.

Since I intend to remove it, perhaps we do not update the fixture with this PR -- or, the next PR removes default including the possibleTypes import completely.

If next PR, then this PR can me merged.

@Tobbe Tobbe marked this pull request as draft November 20, 2023 23:44
@Tobbe
Copy link
Member Author

Tobbe commented Nov 20, 2023

Converting to draft for now. The plan is to update the Trusted Document implementation to not include those changes in a default app, so this update to the test project should not be needed

@virtuoushub virtuoushub mentioned this pull request Dec 12, 2023
Closed
@dthyresson
Copy link
Contributor

Think this can be closed since do not need this file as part of CRWA or test fixtures. See #9594

@dthyresson dthyresson closed this Dec 12, 2023
@jtoar jtoar removed this from the next-release milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dthyresson dthyresson dthyresson left review comments

Assignees
No one assigned
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tobbe @dthyresson @jtoar