fix(crwa): pin Node.js version in .nvmrc
#9614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
approved these changes
Dec 1, 2023
jtoar
added a commit
that referenced
this pull request
Dec 2, 2023
@Tobbe and I reproduced Netlify deploys failing on Node.js with the following Prisma error (only during run, not build, curiously): ``` Prisma Client could not locate the Query Engine for runtime "rhel-openssl-3.0.x".This happened because Prisma Client was generated for "debian-openssl-1.1.x", but the actual deployment required "rhel-openssl-3.0.x" ``` Netlify was deploying with Node.js 20, even if we set the `NODE_VERSION` env var to `18` in Netlify's deploy settings. It seemed like the `.nvmrc` file (which specified any lts version: `lts/*`) was taking precedence over the NODE_VERSION env var. This PR pins the Node.js lts version to 18 in the .nvmrc. We're not sure if we even need to ship with this file but this seemed like the safer change for now. Update: @Tobbe and I tried removing the `.nvmrc` file in a test deploy. Netlify defaulted to Node.js 16 which also isn't what we want, so it should stay.
jtoar
added a commit
that referenced
this pull request
Dec 2, 2023
@Tobbe and I reproduced Netlify deploys failing on Node.js with the following Prisma error (only during run, not build, curiously): ``` Prisma Client could not locate the Query Engine for runtime "rhel-openssl-3.0.x".This happened because Prisma Client was generated for "debian-openssl-1.1.x", but the actual deployment required "rhel-openssl-3.0.x" ``` Netlify was deploying with Node.js 20, even if we set the `NODE_VERSION` env var to `18` in Netlify's deploy settings. It seemed like the `.nvmrc` file (which specified any lts version: `lts/*`) was taking precedence over the NODE_VERSION env var. This PR pins the Node.js lts version to 18 in the .nvmrc. We're not sure if we even need to ship with this file but this seemed like the safer change for now. Update: @Tobbe and I tried removing the `.nvmrc` file in a test deploy. Netlify defaulted to Node.js 16 which also isn't what we want, so it should stay.
jtoar
added a commit
that referenced
this pull request
Dec 2, 2023
@Tobbe and I reproduced Netlify deploys failing on Node.js with the following Prisma error (only during run, not build, curiously): ``` Prisma Client could not locate the Query Engine for runtime "rhel-openssl-3.0.x".This happened because Prisma Client was generated for "debian-openssl-1.1.x", but the actual deployment required "rhel-openssl-3.0.x" ``` Netlify was deploying with Node.js 20, even if we set the `NODE_VERSION` env var to `18` in Netlify's deploy settings. It seemed like the `.nvmrc` file (which specified any lts version: `lts/*`) was taking precedence over the NODE_VERSION env var. This PR pins the Node.js lts version to 18 in the .nvmrc. We're not sure if we even need to ship with this file but this seemed like the safer change for now. Update: @Tobbe and I tried removing the `.nvmrc` file in a test deploy. Netlify defaulted to Node.js 16 which also isn't what we want, so it should stay.
jtoar
added a commit
that referenced
this pull request
Dec 2, 2023
@Tobbe and I reproduced Netlify deploys failing on Node.js with the following Prisma error (only during run, not build, curiously): ``` Prisma Client could not locate the Query Engine for runtime "rhel-openssl-3.0.x".This happened because Prisma Client was generated for "debian-openssl-1.1.x", but the actual deployment required "rhel-openssl-3.0.x" ``` Netlify was deploying with Node.js 20, even if we set the `NODE_VERSION` env var to `18` in Netlify's deploy settings. It seemed like the `.nvmrc` file (which specified any lts version: `lts/*`) was taking precedence over the NODE_VERSION env var. This PR pins the Node.js lts version to 18 in the .nvmrc. We're not sure if we even need to ship with this file but this seemed like the safer change for now. Update: @Tobbe and I tried removing the `.nvmrc` file in a test deploy. Netlify defaulted to Node.js 16 which also isn't what we want, so it should stay.
jtoar
added a commit
that referenced
this pull request
Dec 2, 2023
@Tobbe and I reproduced Netlify deploys failing on Node.js with the following Prisma error (only during run, not build, curiously): ``` Prisma Client could not locate the Query Engine for runtime "rhel-openssl-3.0.x".This happened because Prisma Client was generated for "debian-openssl-1.1.x", but the actual deployment required "rhel-openssl-3.0.x" ``` Netlify was deploying with Node.js 20, even if we set the `NODE_VERSION` env var to `18` in Netlify's deploy settings. It seemed like the `.nvmrc` file (which specified any lts version: `lts/*`) was taking precedence over the NODE_VERSION env var. This PR pins the Node.js lts version to 18 in the .nvmrc. We're not sure if we even need to ship with this file but this seemed like the safer change for now. Update: @Tobbe and I tried removing the `.nvmrc` file in a test deploy. Netlify defaulted to Node.js 16 which also isn't what we want, so it should stay.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tobbe and I reproduced Netlify deploys failing on Node.js with the following Prisma error (only during run, not build, curiously):
Netlify was deploying with Node.js 20, even if we set the
NODE_VERSIONenv var to18in Netlify's deploy settings. It seemed like the.nvmrcfile (which specified any lts version:lts/*) was taking precedence over the NODE_VERSION env var.This PR pins the Node.js lts version to 18 in the .nvmrc. We're not sure if we even need to ship with this file but this seemed like the safer change for now.
Update: @Tobbe and I tried removing the
.nvmrcfile in a test deploy. Netlify defaulted to Node.js 16 which also isn't what we want, so it should stay.