fix(CLI): fix getDevNodeOptions
#9735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
force-pushed
the
ds-cli/fix-node-options
branch
from
9138be5
to
a34e960
Compare
jtoar
commented
Dec 20, 2023
1 task
Tobbe
pushed a commit
that referenced
this pull request
Dec 21, 2023
Fixes #9733. - don't rely on the function `getDevNodeOptions` to return the whole env var string (`NODE_OPTIONS="..."`); just return the value of `NODE_OPTIONS` - fix the quoting issue #9733 was specifically about where the env var string would be inserted as `NODE_OPTIONS=--inspect --enable-source-maps` causing spawn to think `--enable-source-maps` was meant for something else - fix the test; the mock value for `NODE_OPTIONS` was incorrect resulting in a false positive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9733.
getDevNodeOptionsto return the whole env var string (NODE_OPTIONS="..."); just return the value ofNODE_OPTIONSNODE_OPTIONS=--inspect --enable-source-mapscausing spawn to think--enable-source-mapswas meant for something elseNODE_OPTIONSwas incorrect resulting in a false positive