chore(build): Avoid prebuilding api side, instead use an esbuild plugin #9767

dac09 · 2023-12-28T08:05:15Z

Resurrecting this again, to see if I can get CI more stable this time

2nd edition Implementation: With the second edition, I'm trying esbuild's watcher - rather than chokidar
This is a no go ❌, because when new files are introduced the watcher isn't triggered.

3rd edition implementation: Use esbuild's rebuild function that may provide performance benefits

Old PR #7672

This reverts commit b3ece67.

…p-prebuild * 'main' of github.com:redwoodjs/redwood: chore(deps): update dependency @types/uuid to v9.0.1 (redwoodjs#7680) chore(deps): update dependency @replayio/playwright to v0.3.23 (redwoodjs#7677) chore(deps): update dependency @npmcli/arborist to v6.2.3 (redwoodjs#7675) chore(deps): update dependency @envelop/types to v3.0.2 (redwoodjs#7674) chore: add codemod for clerk fix in v4.2.0 (redwoodjs#7676) chore(deps): update dependency @clerk/types to v3.28.1 (redwoodjs#7652) chore(deps): update dependency @envelop/testing to v5.0.6 (redwoodjs#7673) Update directives.md (redwoodjs#7670) fix(deps): update dependency vscode-languageserver-types to v3.17.3 (redwoodjs#7636) Fix `yarn rw exec` to set nonzero exit code on error (redwoodjs#7660)

…p-prebuild * 'main' of github.com:redwoodjs/redwood: (1608 commits) Docker: Update to work with corepack and yarn v4 (redwoodjs#9764) [RFC]: useRoutePaths (redwoodjs#9755) Adds a note about the two commands you will use with your schema to the top of the schema file (redwoodjs#8589) docs: Supertokens.md: Fix typo (redwoodjs#9765) Fix supertokens docs & integration issues (redwoodjs#9757) fix(apollo): Enhance error differently for Suspense Cells (redwoodjs#9640) SSR smoke-test: Use <Metadata /> (redwoodjs#9763) chore(deps): update dependency @types/qs to v6.9.11 (redwoodjs#9761) chore(ci): Better error handling in detectChanges.mjs (redwoodjs#9762) fix(path-alias): Fix aliasing of paths using ts/jsconfig (redwoodjs#9574) chore(deps): update dependency @types/yargs to v17.0.32 (redwoodjs#9759) Make it easier to find useMatch docs (redwoodjs#9756) chore(unit tests): Use side-effect import to fix TS errors (redwoodjs#9754) fix(context): Refactor context (redwoodjs#9371) docs: Replaced deprecated <Set private> with PrivateSet within router.md (redwoodjs#9749) add TS support for storybook preview tsx config extension (redwoodjs#9309) fix(studio): Fix windows path issues (redwoodjs#9752) chore(tasks): Add comparison view to nmHoisting visualisation (redwoodjs#9751) chore(cli): make fs modules used in the CLI consistent (redwoodjs#9746) ...

…p-prebuild-try-2 * 'main' of github.com:redwoodjs/redwood: fix(server): error early on incompatible config (apiHost and apiUrl) (redwoodjs#9808) chore(esm): convert crwa to esm and bundle (redwoodjs#9786) chore(cli): More robust isAwaitable (redwoodjs#9806) chore(ci): Update task names to say "node 20" (redwoodjs#9805) Use TS for rebuild-test-project-fixture script (redwoodjs#9804) chore: bump TSTyche (redwoodjs#9803) docs(fragments): Typo, grammar and formatting fixes (redwoodjs#9802)

packages/babel-config/src/__tests__/prebuildApiFile.test.ts

packages/babel-config/src/api.ts

packages/internal/src/__tests__/build_api.test.ts

packages/internal/src/build/api.ts

…p-prebuild-try-2 * 'main' of github.com:redwoodjs/redwood: chore: Improved Possible Types DX and Framework integration for GraphQL Fragments with Union and Interface support (redwoodjs#9594)

tasks/e2e/cypress.config.js

dac09 · 2024-01-08T12:11:11Z

Thanks for the review @Tobbe - going to wait till Dom and I get a chance to go through this together in detail - there's a chance CI won't catch finer details here.

…p-prebuild-try-2 * 'main' of github.com:redwoodjs/redwood: Fastify config: Use exact file extension in log message (redwoodjs#9828) Remove unused Fastify plugin (redwoodjs#9827) Add trusted-documents to fragments CI smoke-test (redwoodjs#9826) prerender: Enable Trusted Documents support (redwoodjs#9825) trustedDocuments.test.ts: Format source cli: add missing dep jscodeshift (redwoodjs#9823) graphql setup fragments: Move telemetry to main handler (redwoodjs#9819) feat: Adds Setup CLI Command to Configure GraphQL Trusted Documents (redwoodjs#9800) Update cli tsconfig to reference used packages (redwoodjs#9822) fragments setup: newline fix + refactor->rename (redwoodjs#9821) yarn rw setup graphql fragments (redwoodjs#9811)

dac09 · 2024-01-15T08:52:34Z

Comments addressed!

@jtoar I'll let you do the final check and merge when ready :)

…edwood into try/setupScenario-multiple-tests * 'try/setupScenario-multiple-tests' of github.com:dac09/redwood: (235 commits) chore(project-config): switch to vitest (#9864) chore(ci): Fix CRWA telemetry check (#9865) chore(crwa): update e2e test to handle yarn install patch (#9862) feat(crwa): Always install using yarn v4 (#9861) fix(cli): Skip Studio when running `rw upgrade` (#9860) fix(studio): Upgrade to 11.0.1 and enable web-side (#9858) feat(server file): add `createServer` (#9845) chore(crwa): set `REDWOOD_CI` and `REDWOOD_DISABLE_TELEMETRY` (#9857) Fix(crwa): Exit 0 after Quit install (#9856) chore(crwa): switch to vitest (#9855) chore(api): Switch to use vitest over jest (#9853) fix(server): ensure consistency between CLI serve entrypoints regarding help and strict (#9809) Improve how the api-server watch command works (#9841) docs(typo): correct grammar in realtime docs (#9850) Add support for Prisma Bytes and GraphQL scalar Byte (#9847) packages/cli: Switch from substr (deprecated) to slice (#9849) mapPrismaScalarToPagePropTsType: Fix Decimal test case (#9846) chore(build): Avoid prebuilding api side, instead use an esbuild plugin (#9767) Fix url query param encoding (#9844) chore(fwtools): handle existing resolutions in tarsync (#9840) ...

dac09 and others added 30 commits February 22, 2023 15:59

Use async build

096674f

Fix tests

cd49f30

Remove graphql-tag plugin because it doesnt work anyway

b3ece67

Explain use of prebuildApiFiles

7f1c721

Rename prebuild function

bd2c985

Remove redundant code

9c8fbde

Revert "Remove graphql-tag plugin because it doesnt work anyway"

00a4a85

This reverts commit b3ece67.

Fix failing nftPack test

8932833

Fix sourcemaps/debugging with breakpoints

480a257

Fix api build test

3f84ed2

Try disabling telemetry on CLI tests

d86822e

Try mocking telemetry

f2ebf21

Add "." to esbuild filter

113ce60

Remove prebuild

dc03ee1

Remove unused import

0f8f8b2

Increase test timeout

4863387

Merge branch 'main' into feat/api-skip-prebuild

c862986

Mock FS in tests

5d6557e

Merge branch 'main' into feat/api-skip-prebuild

3308408

Fix test after merge

5b8fdd2

Fix merge conflicts

fd575ba

Fix merge conflicts

de923ae

fix tests on windows

3010ad9

Merge branch 'main' into feat/api-skip-prebuild

18db1cd

Merge branch 'main' into feat/api-skip-prebuild

4c1928b

Undo jest config change

333cac8

Undo telemetry change

9bac85b

Fix tests

4aa171c

jtoar and others added 5 commits January 6, 2024 22:05

add dev server logs, fail fast, bump delay restart

04a02cf

Try making api transform async

4fb918a

Explain LRU comment

00c8370

Bit more cleanup

8ad4753

dac09 marked this pull request as ready for review January 8, 2024 09:34