Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otel): Support OTel timestamp which is simple string #48

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

Josh-Walker-GM
Copy link
Contributor

Problem
It appears that in some situations the timestamps received during OTel ingestion as strings rather than objects that contain details of the corresponding unix nanosecond timestamp.

See: https://community.redwoodjs.com/t/opentelemetry-support-experimental/4772/17

Changes

  1. When we receive a string just process that rather than go through the object handling logic.

@Josh-Walker-GM Josh-Walker-GM self-assigned this Mar 6, 2024
@dthyresson dthyresson merged commit 3c29eba into main Mar 7, 2024
@dthyresson dthyresson deleted the jgmw-fix/otel-timestamp-format branch March 7, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants