Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds loading, failure/error, and empty states to Line Charts #9

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

dthyresson
Copy link
Collaborator

This PR adds some improved empty, loading, and failure/error state visualization by:

Empty

image

Failure

image

Loading

image

Success

image

@dthyresson dthyresson changed the title feat: Add loading, fail, and empty states to line charts feat: Adds loading, failure/error, and empty states to Line Charts Jan 23, 2024
@dthyresson dthyresson marked this pull request as ready for review January 23, 2024 12:56
@dthyresson dthyresson requested a review from Tobbe January 23, 2024 12:56
@Tobbe Tobbe merged commit 08bd38c into main Jan 23, 2024
@Tobbe Tobbe deleted the dt-perf-chart-states branch January 23, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants