Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ResolveInfo import to be compatible with Graphene 3.x #36

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Fix ResolveInfo import to be compatible with Graphene 3.x #36

merged 1 commit into from
Mar 9, 2022

Conversation

jmp
Copy link
Contributor

@jmp jmp commented Nov 22, 2021

Fixes #35 by importing ResultInfo from graphene instead of graphql.

This should be compatible with both Graphene 2.x and 3.x.

Latest versions of graphql-core expose ResultInfo as
GraphQLResultInfo. A compatible name can be imported
via Graphene's public API.
@jmp jmp changed the title Fix ResolveInfo import Fix ResolveInfo import to be compatible with Graphene 3.x Nov 22, 2021
@redzej
Copy link
Owner

redzej commented Nov 25, 2021

Hello @jmp, thanks for PR. There was error when i run test check on this code, but i think it is the problem is with test itself - i need to run it locally (and fix). Commit looks ok. I will approve after i fix test case and re-run github check.

@jmp
Copy link
Contributor Author

jmp commented Nov 28, 2021

Thanks for taking a look, @redzej!

I believe the problem with the tests is the current requirements.txt:

One solution would be to remove the graphene dependency from requirements.txt. I guess it shouldn't be needed because graphene-django already depends on it. Or, pin it to Graphene 2.x.

Other option would be to allow pre-release versions of graphene-django (e.g. Graphene-Django 3.0.0b7) as those support Graphene 3.0.

@redzej redzej self-assigned this Dec 6, 2021
@redzej redzej added the bugfix label Dec 6, 2021
@redzej
Copy link
Owner

redzej commented Dec 6, 2021

Sorry for the delay. I am going to fix problem with failing github check today and approve this PR.

@gustav0
Copy link

gustav0 commented Jan 6, 2022

@redzej any updates on this? Anything I can help you with?

@redzej redzej merged commit a1c6fbc into redzej:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing ResolveInfo from 'graphql' fails with latest versions of Graphene
3 participants