fix: ogp image for published page (#17)

* - use project image as fallback image if the public image does not exists * - use project data as fallback if the public data does not exists * - fix routing
reearth · Jul 7, 2021 · dcb4b08 · dcb4b08
1 parent 25da0d1
commit dcb4b08
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 5 deletions.
diff --git a/internal/app/public.go b/internal/app/public.go
@@ -46,7 +46,7 @@ func publicAPI(
 	})
 
 	r.GET("/published/:name", func(c echo.Context) error {
-		name := c.Param("string")
+		name := c.Param("name")
 		if name == "" {
 			return echo.ErrNotFound
 		}
@@ -60,7 +60,7 @@ func publicAPI(
 	})
 
 	r.GET("/published_data/:name", func(c echo.Context) error {
-		name := c.Param("string")
+		name := c.Param("name")
 		if name == "" {
 			return echo.ErrNotFound
 		}

diff --git a/internal/usecase/interfaces/published.go b/internal/usecase/interfaces/published.go
@@ -19,10 +19,23 @@ type ProjectPublishedMetadata struct {
 }
 
 func ProjectPublishedMetadataFrom(prj *project.Project) ProjectPublishedMetadata {
+	title := prj.PublicTitle()
+	description := prj.PublicDescription()
+	image := prj.PublicImage()
+	if title == "" {
+		title = prj.Name()
+	}
+	if description == "" {
+		description = prj.Description()
+	}
+	if image == "" {
+		image = prj.ImageURL().String()
+	}
+
 	return ProjectPublishedMetadata{
-		Title:             prj.PublicTitle(),
-		Description:       prj.PublicDescription(),
-		Image:             prj.PublicImage(),
+		Title:             title,
+		Description:       description,
+		Image:             image,
 		Noindex:           prj.PublicNoIndex(),
 		IsBasicAuthActive: prj.IsBasicAuthActive(),
 		BasicAuthUsername: prj.BasicAuthUsername(),