Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: ogp image for published page #17

Merged
merged 5 commits into from Jul 7, 2021
Merged

Conversation

yk-eukarya
Copy link
Contributor

Overview

What I've done

  • return project image for OPG if public image does not exists
  • fix routing

What I haven't done

How I tested

Tested by calling the api manually

Which point I want you to review particularly

Memo

@yk-eukarya yk-eukarya added the bug Something isn't working label Jun 28, 2021
@yk-eukarya yk-eukarya self-assigned this Jun 28, 2021
@yk-eukarya yk-eukarya changed the title Fix/ogp image for published page Fix: ogp image for published page Jun 28, 2021
@yk-eukarya yk-eukarya changed the title Fix: ogp image for published page fix: ogp image for published page Jun 28, 2021
@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #17 (a94b1df) into main (25da0d1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   16.30%   16.30%           
=======================================
  Files         196      196           
  Lines       39225    39225           
=======================================
  Hits         6394     6394           
  Misses      31865    31865           
  Partials      966      966           

@yk-eukarya yk-eukarya requested a review from KaWaite June 29, 2021 07:17
Copy link
Contributor

@mimoham24 mimoham24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the logic please ask @KaWaite or @HideBa , but technically looks good

Copy link
Member

@HideBa HideBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except where I left the comment. 👍

@yk-eukarya yk-eukarya merged commit dcb4b08 into main Jul 7, 2021
@yk-eukarya yk-eukarya deleted the fix/OGPImageForPublishedPage branch July 7, 2021 05:09
rot1024 added a commit that referenced this pull request Jul 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
5 participants