Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: google analytics for scene #10

Merged
merged 6 commits into from Jun 4, 2021
Merged

feat: google analytics for scene #10

merged 6 commits into from Jun 4, 2021

Conversation

HideBa
Copy link
Member

@HideBa HideBa commented Jun 4, 2021

  • Added google analytics properties on Scene

@codecov
Copy link

codecov bot commented Jun 4, 2021 •
edited

Codecov Report

Merging #10 (aff07d1) into main (f7866c0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   37.04%   37.04%           
=======================================
  Files         176      176           
  Lines       13824    13824           
=======================================
  Hits         5121     5121           
  Misses       7913     7913           
  Partials      790      790

KaWaite
KaWaite reviewed Jun 4, 2021
View reviewed changes
pkg/builtin/manifest.yml Outdated Show resolved Hide resolved
KaWaite
KaWaite reviewed Jun 4, 2021
View reviewed changes
pkg/builtin/manifest.yml Outdated Show resolved Hide resolved
KaWaite
KaWaite reviewed Jun 4, 2021
View reviewed changes
Copy link
Member

@KaWaite KaWaite left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are we embedding it into the project? I see you are adding the options to choose to do so, but I don't understand where the logic is setting it? Or was that done already?
Edit: Nevermind.. I am assuming that'll happen on the frontend! My bad..

KaWaite
KaWaite suggested changes Jun 4, 2021
View reviewed changes
Copy link
Member

@KaWaite KaWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again...my bad, approved but I asked for english changes.

@HideBa
Copy link
Member Author

HideBa commented Jun 4, 2021

@KaWaite Thanks for reviewing quickly.

rot1024
rot1024 previously approved these changes Jun 4, 2021
View reviewed changes
pkg/builtin/manifest_ja.yml Outdated Show resolved Hide resolved
@HideBa @rot1024
Update pkg/builtin/manifest_ja.yml
d3ff819 
Co-authored-by: rot1024 <aayhrot@gmail.com>
KaWaite
KaWaite previously approved these changes Jun 4, 2021
View reviewed changes
@HideBa HideBa merged commit b442490 into main Jun 4, 2021
@HideBa HideBa deleted the feat/ga branch June 4, 2021 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KaWaite KaWaite KaWaite approved these changes

@rot1024 rot1024 rot1024 left review comments

@yk-eukarya yk-eukarya Awaiting requested review from yk-eukarya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@HideBa @rot1024 @KaWaite