Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

refactor: introduce generics, reorganize GraphQL schema #135

Merged
merged 15 commits into from Apr 20, 2022
Merged

refactor: introduce generics, reorganize GraphQL schema #135

merged 15 commits into from Apr 20, 2022

Conversation

rot1024
Copy link
Member

@rot1024 rot1024 commented Apr 11, 2022

Use generics since Go v1.18 to reduce codes and improve function versatility. Also GraphQL schema was needed to be refactored.

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #135 (224b879) into main (7ec76aa) will increase coverage by 0.00%.
The diff coverage is 1.24%.

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #135    +/-   ##
========================================
  Coverage   36.67%   36.67%            
========================================
  Files         330      331     +1     
  Lines       29353    29891   +538     
========================================
+ Hits        10766    10964   +198     
- Misses      17582    17925   +343     
+ Partials     1005     1002     -3     
Impacted Files Coverage Δ
internal/adapter/gql/context.go 0.00% <0.00%> (ø)
internal/adapter/gql/gqlmodel/convert_asset.go 0.00% <0.00%> (ø)
internal/adapter/gql/gqlmodel/convert_dataset.go 0.00% <0.00%> (ø)
internal/adapter/gql/gqlmodel/convert_layer.go 0.00% <0.00%> (ø)
internal/adapter/gql/gqlmodel/convert_plugin.go 0.00% <0.00%> (ø)
internal/adapter/gql/gqlmodel/convert_project.go 0.00% <0.00%> (ø)
internal/adapter/gql/gqlmodel/convert_property.go 1.30% <0.00%> (+0.11%) ⬆️
internal/adapter/gql/gqlmodel/convert_scene.go 0.00% <0.00%> (ø)
...ternal/adapter/gql/gqlmodel/convert_scene_align.go 0.00% <0.00%> (ø)
internal/adapter/gql/gqlmodel/convert_tag.go 0.00% <0.00%> (ø)
... and 126 more

@rot1024 rot1024 marked this pull request as ready for review April 18, 2022 10:07
@rot1024 rot1024 changed the title refactor: use generics for IDs refactor: introduce generics for IDs Apr 18, 2022
@rot1024 rot1024 changed the title refactor: introduce generics for IDs refactor: introduce generics Apr 18, 2022
@rot1024 rot1024 changed the title refactor: introduce generics refactor: introduce generics, reorganize GraphQL schema Apr 19, 2022
@rot1024 rot1024 merged commit 04a098d into main Apr 20, 2022
@rot1024 rot1024 deleted the go118 branch April 20, 2022 03:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant