Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: property fields in a property list cannot be removed #160

Merged
merged 3 commits into from Jul 19, 2022

Conversation

yk-eukarya
Copy link
Contributor

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@yk-eukarya yk-eukarya requested a review from rot1024 as a code owner July 15, 2022 16:20
@yk-eukarya yk-eukarya self-assigned this Jul 15, 2022
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #160 (54f10af) into main (62dede2) will decrease coverage by 0.00%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
- Coverage   34.87%   34.87%   -0.01%     
==========================================
  Files         351      351              
  Lines       31901    31904       +3     
==========================================
  Hits        11125    11125              
- Misses      19763    19766       +3     
  Partials     1013     1013              
Impacted Files Coverage Δ
pkg/property/property.go 45.70% <0.00%> (-0.30%) ⬇️
pkg/property/pointer.go 63.84% <100.00%> (ø)

.gitignore Outdated Show resolved Hide resolved
pkg/property/property.go Outdated Show resolved Hide resolved
@rot1024 rot1024 changed the title fix: remove property field issue fix: property fields in a property list cannot be removed Jul 19, 2022
@yk-eukarya yk-eukarya merged commit 358237b into main Jul 19, 2022
@yk-eukarya yk-eukarya deleted the fix/remove_property_field branch July 19, 2022 09:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants