This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… function and remove function + testing for all so far
…ate types, update convert.go, update extension.go as well as its builder and tests
…hat aren't related to the align system. fixed conversion logic for empty WidgetLayout fixed conversion logic for empty DefaultLocation
Update plugin.WidgetLayout use and add WidgetLayout where necessary
add Move method
Pull out widgetlayout and conditionally add widget to widgetalignsystem in AddWidget Add SetExtended method to Widget Add extended to UpdateWidgetParam Combine Move and Reorder methods + tests
Add WidgetIds and Alignment methods to alignSystem Update graphql Etc
Make widgetIds a slice of pointers to the ids Update add test to include two additions Update logic in scene interactor to be more deliberate Update scene controller to avoid assignment if nil
Conversions for graphql and structs Updated graphql schemas + gens
simplify conditionals/avoid lint warning
Codecov Report
@@ Coverage Diff @@
## main #19 +/- ##
==========================================
- Coverage 16.57% 16.52% -0.06%
==========================================
Files 241 246 +5
Lines 41399 42966 +1567
==========================================
+ Hits 6862 7099 +237
- Misses 33545 34862 +1317
- Partials 992 1005 +13
|
Add align to widget update Add widgetLayout to reearth widgets Fix/improve conditionals
Add extended bool to sceneWidget (graphql) Move up updating align to top of if statements Add Equal method to widgetId
Migration for adding alignSystem to scene
Remove commented out code in scene builder
Fix nil pointer errors.
Co-authored-by: KaWaite <KaWaite@users.noreply.github.com> Co-authored-by: HideBa <HideBa@users.noreply.github.com>
rot1024
approved these changes
Sep 23, 2021
rot1024
suggested changes
Sep 23, 2021
rot1024
previously approved these changes
Sep 24, 2021
rot1024
approved these changes
Sep 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What I've done
What I haven't done
How I tested
Which point I want you to review particularly
Memo