This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
fix: import dataset from google sheet bug #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #23 +/- ##
=======================================
Coverage 16.00% 16.00%
=======================================
Files 198 198
Lines 40002 40002
=======================================
Hits 6401 6401
Misses 32633 32633
Partials 968 968
|
rot1024
approved these changes
Jul 13, 2021
HideBa
approved these changes
Jul 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What I've done
Check if the column has an empty label => ignore it
Note
This will affect the import from file also in the same way
What I haven't done
How I tested
Which point I want you to review particularly
Memo