Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Refine dataset import #26

Merged
merged 3 commits into from Jul 28, 2021
Merged

feat: Refine dataset import #26

merged 3 commits into from Jul 28, 2021

Conversation

yk-eukarya
Copy link
Contributor

Overview

Add ability to set the layer name from dataset column

What I've done

  • Extend AddLayerGroupInput to accept optional markerTitleFieldId
  • Use selected Field value as layer name

What I haven't done

How I tested

Which point I want you to review particularly

specially the graphQL schema so we can start the front-end development

Memo

The layer primitive type was implemented I've just tested it

- Extend AddLayerGroupInput to accept optional markerTitleFieldId
- Use selected Field value as layer name
@yk-eukarya yk-eukarya self-assigned this Jul 19, 2021
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #26 (5844a5b) into main (8ad1f80) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   15.81%   15.80%   -0.01%     
==========================================
  Files         213      213              
  Lines       40663    40680      +17     
==========================================
  Hits         6431     6431              
- Misses      33263    33280      +17     
  Partials      969      969              
Impacted Files Coverage Δ
internal/graphql/generated.go 0.00% <0.00%> (ø)
internal/usecase/interactor/layer.go 4.27% <0.00%> (-0.03%) ⬇️

schema.graphql Outdated Show resolved Hide resolved
- use representativeFieldID to set layer title
@yk-eukarya yk-eukarya merged commit 5dd3dba into main Jul 28, 2021
@yk-eukarya yk-eukarya deleted the feat/RefineDatasetImport branch July 28, 2021 07:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants