Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: dataset layers are not exported correctly #36

Merged
merged 3 commits into from Aug 6, 2021
Merged

Conversation

mimoham24
Copy link
Contributor

@mimoham24 mimoham24 commented Aug 4, 2021

Overview

fixing the layer exporting bug

What I've done

encoder now fetches the property values first, if no values found -> fetch values from dataset

What I haven't done

How I tested

export all types "KML, CZML, GeoJSON, SHP"

Which point I want you to review particularly

Memo

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #36 (12401dd) into main (8742dba) will decrease coverage by 0.01%.
The diff coverage is 63.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   16.59%   16.58%   -0.02%     
==========================================
  Files         222      222              
  Lines       41150    41186      +36     
==========================================
  Hits         6830     6830              
- Misses      33328    33364      +36     
  Partials      992      992              
Impacted Files Coverage Δ
pkg/layer/encoding/shp.go 59.54% <46.15%> (-2.86%) ⬇️
pkg/layer/encoding/geojson.go 54.81% <62.50%> (-4.39%) ⬇️
pkg/layer/encoding/kml.go 59.32% <65.85%> (-2.30%) ⬇️
pkg/layer/encoding/czml.go 53.80% <68.42%> (-3.35%) ⬇️

rot1024
rot1024 previously approved these changes Aug 4, 2021
Copy link
Member

@rot1024 rot1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are ok but I've tried to make the code a little more readable.

pkg/layer/encoding/czml.go Outdated Show resolved Hide resolved
pkg/layer/encoding/czml.go Outdated Show resolved Hide resolved
pkg/layer/encoding/czml.go Outdated Show resolved Hide resolved
@rot1024 rot1024 changed the title fix: layer encoding fix: dataset layers are not exported correctly Aug 4, 2021
HideBa
HideBa previously approved these changes Aug 5, 2021
Copy link
Member

@HideBa HideBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@mimoham24 mimoham24 dismissed stale reviews from HideBa and rot1024 via c585b4a August 5, 2021 12:00
@mimoham24 mimoham24 merged commit 0b8c007 into main Aug 6, 2021
@mimoham24 mimoham24 deleted the fix-layer-encoding branch August 6, 2021 07:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants