This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #40 +/- ##
==========================================
- Coverage 16.60% 16.40% -0.20%
==========================================
Files 223 241 +18
Lines 41198 41693 +495
==========================================
Hits 6841 6841
- Misses 33365 33860 +495
Partials 992 992
|
yk-eukarya
previously approved these changes
Aug 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mimoham24
previously approved these changes
Aug 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just wanted to remind you that the code coverage is not so good
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, the GraphQL code was very difficult to understand, so I refactored it to make it easier to change the implementation of GraphQL resolvers.
internal/adapter/gql
internal/adapter/graphql
internal/graphql
gqldataloader
) and models (gqlmodel
)gqlmodel
are now public and ready to write unit testsgql
package have been abolishedupdatePropertyValue*
mutations (updatePropertyValue
mutation replaces them)Note: From now on, you can use this command to generate code from the GraphQL schema:
go generate ./internal/adapter/gql