Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

chore: update golang version and modules #51

Merged
merged 3 commits into from Sep 16, 2021
Merged

chore: update golang version and modules #51

merged 3 commits into from Sep 16, 2021

Conversation

mimoham24
Copy link
Contributor

@mimoham24 mimoham24 commented Sep 15, 2021

Overview

7upgrading to glang version 1.15

What I've done

  • update golang locally
  • go get -u
  • go mod tidy -go=1.17 (equals to go mod edit -go=1.17 and go mod tidy)
  • update go version for github workflows and DOCKER file

What I haven't done

How I tested

  • run test
  • run and build the project

Which point I want you to review particularly

Memo

language changes:

  • Conversions from slice to array pointer: An expression s of type []T may now be converted to array pointer type *[N]T. If a is the result of such a conversion, then corresponding indices that are in range refer to the same underlying elements: &a[i] == &s[i] for 0 <= i < N. The conversion panics if len(s) is less than N.
  • unsafe.Add: unsafe.Add(ptr, len) adds len to ptr and returns the updated pointer unsafe.Pointer(uintptr(ptr) + uintptr(len)).
  • unsafe.Slice: For expression ptr of type *T, unsafe.Slice(ptr, len) returns a slice of type []T whose underlying array starts at ptr and whose length and capacity are len.

@mimoham24 mimoham24 changed the title sys: update golang version and modules refactor: update golang version and modules Sep 15, 2021
@mimoham24 mimoham24 changed the title refactor: update golang version and modules chore: update golang version and modules Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #51 (77b7d36) into main (d3360b3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   16.57%   16.57%           
=======================================
  Files         241      241           
  Lines       41399    41399           
=======================================
  Hits         6862     6862           
  Misses      33545    33545           
  Partials      992      992           

Copy link
Member

@rot1024 rot1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change .github/workflows/*.yml and Dockerfile also

@mimoham24 mimoham24 merged commit 33f4c7c into main Sep 16, 2021
@mimoham24 mimoham24 deleted the self-update branch September 16, 2021 09:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants