Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: invalid extension data from GraphQL, plugin manifest schema improvement, more friendly error from manifest parser #56

Merged
merged 9 commits into from Sep 28, 2021

Conversation

rot1024
Copy link
Member

@rot1024 rot1024 commented Sep 28, 2021

  • Fix invalid extension title and description are returned on GraphQL
  • Make errors more friendly from plugin manifest parser
  • Plugin manifest schema improvement
    • Make "visualizer" field optional in extensions
    • Rename title field to "name" in root and extensions

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #56 (7237044) into main (eb1db48) will increase coverage by 0.00%.
The diff coverage is 36.70%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   16.51%   16.51%           
=======================================
  Files         246      246           
  Lines       42988    43009   +21     
=======================================
+ Hits         7099     7103    +4     
- Misses      34884    34899   +15     
- Partials     1005     1007    +2     
Impacted Files Coverage Δ
internal/adapter/gql/generated.go 0.00% <0.00%> (ø)
internal/infrastructure/mongo/mongodoc/plugin.go 0.00% <0.00%> (ø)
internal/usecase/interactor/plugin_upload.go 0.00% <0.00%> (ø)
pkg/plugin/extension_builder.go 93.10% <ø> (ø)
pkg/plugin/pluginpack/package.go 73.91% <25.00%> (ø)
pkg/plugin/manifest/convert.go 88.42% <60.71%> (-3.37%) ⬇️
pkg/plugin/manifest/parser_translation.go 75.80% <100.00%> (ø)
pkg/rerror/error.go 100.00% <100.00%> (ø)

@rot1024 rot1024 merged commit 92d1373 into main Sep 28, 2021
@rot1024 rot1024 deleted the fix/plugin-manifest-2 branch September 28, 2021 09:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant