This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
feat: tag system #67
Merged
feat: tag system #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: tag system domain models * refactor: * add tag interface * tag -> group and tag->item conversation * testing: generate test cases for the tagID * resolve notes * fix unit tests errors * add NewId test code fix NewId func * add more test cases refactor some parts
* feat: tag system data-layer (mongo) * remove len > 0 check * goimport * Update pkg/tag/group_builder.go Co-authored-by: rot1024 <aayhrot@gmail.com> * Update pkg/tag/item_builder.go Co-authored-by: rot1024 <aayhrot@gmail.com> * rename itemFrom and groupFrom funcs Co-authored-by: rot1024 <aayhrot@gmail.com>
* tag item and group schema * feat: creat tags (GQL schema) * tag items and tag groups resolvers * datalayer (dummy memory) and usecases * receive list by reference * check if nil for list * resolve notes * generate new models
* refactor: implement memory infrastructure * test: implement memory infrastructure test cases * test: fix FindByScene test case
* tag item and group schema * feat: creat tags (GQL schema) * tag items and tag groups resolvers * datalayer (dummy memory) and usecases * receive list by reference * check if nil for list * feat: introduce tags to layers * feat: attach/detach tags from layers * fix imports * refactor: resolve notes * test: test units for tags * refactor: resolve notes
* refactor: transform group tags list to reference * feat: attach/detach tags * refactor: use params as use-case input
* test: mongodoc testing * resolve notes
* feat: remove a tag (init) * feat: remove tag * feat: remove tag usecase and infra * resolve notes
* feat: tag system queries * resolve notes
* tag item and group schema * feat: creat tags (GQL schema) * tag items and tag groups resolvers * datalayer (dummy memory) and usecases * receive list by reference * check if nil for list * feat: rename tag group * refactor: rename -> update * resolve notes * resolve notes * change find by id func return type * Merge branch 'tag-system' of https://github.com/reearth/reearth-backend into tag/update-group-label # Conflicts: # internal/adapter/gql/generated.go # internal/adapter/gql/gqlmodel/convert_tag.go * fix testing
…o tag-system # Conflicts: # internal/adapter/gql/generated.go # pkg/plugin/manifest/schema_gen.go
Codecov Report
@@ Coverage Diff @@
## main #67 +/- ##
==========================================
- Coverage 16.51% 16.11% -0.40%
==========================================
Files 246 275 +29
Lines 43060 46328 +3268
==========================================
+ Hits 7110 7465 +355
- Misses 34943 37835 +2892
- Partials 1007 1028 +21
|
rot1024
suggested changes
Oct 25, 2021
rot1024
suggested changes
Oct 25, 2021
rot1024
suggested changes
Oct 25, 2021
rot1024
approved these changes
Oct 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What I've done
What I haven't done
How I tested
Which point I want you to review particularly
Memo