Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: authentication system - mongo storage #84

Merged
merged 6 commits into from
Dec 6, 2021

Conversation

yk-eukarya
Copy link
Contributor

  • Change auth storage into mongo db
  • Some refactoring on structure level

- Repo
@yk-eukarya yk-eukarya self-assigned this Nov 29, 2021
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

❗ No coverage uploaded for pull request base (feat/authentication-system@2632fe9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             feat/authentication-system      #84   +/-   ##
=============================================================
  Coverage                              ?   16.57%           
=============================================================
  Files                                 ?      252           
  Lines                                 ?    43590           
  Branches                              ?        0           
=============================================================
  Hits                                  ?     7227           
  Misses                                ?    35336           
  Partials                              ?     1027           

@yk-eukarya yk-eukarya marked this pull request as ready for review December 1, 2021 06:01
Copy link
Member

@rot1024 rot1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a matter of fact, I thought it would be better to pack the implementation of authentication in appauth package, because in DDD, authentication is a subdomain, not a core domain.

However, your implementation is fine. The package is well separated, so it is unlikely to be a stumbling block for future refactoring.

Requests:

  • Please implement internal/infrastructure/memory/auth.go also.

pkg/auth/builder.go Outdated Show resolved Hide resolved
pkg/auth/builder.go Outdated Show resolved Hide resolved
pkg/auth/client.go Show resolved Hide resolved
internal/infrastructure/mongo/auth_request.go Outdated Show resolved Hide resolved
internal/infrastructure/mongo/auth_request.go Outdated Show resolved Hide resolved
internal/infrastructure/mongo/mongodoc/auth_request.go Outdated Show resolved Hide resolved
internal/usecase/interactor/auth.go Outdated Show resolved Hide resolved
internal/usecase/interactor/auth.go Show resolved Hide resolved
@yk-eukarya yk-eukarya merged commit 3913545 into feat/authentication-system Dec 6, 2021
@yk-eukarya yk-eukarya deleted the auth/mongo-storage branch December 6, 2021 06:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants