This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
feat: authentication system - mongo storage #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yk-eukarya
commented
Nov 29, 2021
- Change auth storage into mongo db
- Some refactoring on structure level
Codecov Report
@@ Coverage Diff @@
## feat/authentication-system #84 +/- ##
=============================================================
Coverage ? 16.57%
=============================================================
Files ? 252
Lines ? 43590
Branches ? 0
=============================================================
Hits ? 7227
Misses ? 35336
Partials ? 1027 |
rot1024
suggested changes
Dec 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a matter of fact, I thought it would be better to pack the implementation of authentication in appauth
package, because in DDD, authentication is a subdomain, not a core domain.
However, your implementation is fine. The package is well separated, so it is unlikely to be a stumbling block for future refactoring.
Requests:
- Please implement
internal/infrastructure/memory/auth.go
also.
rot1024
approved these changes
Dec 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.