Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): copy Icon component from classic #455

Merged
merged 9 commits into from
Jun 1, 2023

Conversation

atnagata
Copy link
Contributor

Overview

copy Icon component to beta from classic .

@atnagata atnagata requested a review from KaWaite as a code owner May 31, 2023 06:52
@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 3fe993f
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/647836ea55c2360007672636
😎 Deploy Preview https://deploy-preview-455--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@atnagata atnagata changed the title Pasona develop feat(web): copy Icon component from classic. May 31, 2023
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #455 (3fe993f) into main (f27b788) will decrease coverage by 16.10%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #455       +/-   ##
===========================================
- Coverage   36.25%   20.16%   -16.10%     
===========================================
  Files         342      710      +368     
  Lines       30988    80992    +50004     
  Branches        0     2146     +2146     
===========================================
+ Hits        11236    16334     +5098     
- Misses      18651    64658    +46007     
+ Partials     1101        0     -1101     
Flag Coverage Δ
server ?
web-beta 20.16% <0.00%> (?)
web-classic 20.16% <0.00%> (?)
web-utils 20.16% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/beta/components/Icon/icons.ts 0.00% <0.00%> (ø)
web/src/beta/components/Icon/index.tsx 0.00% <0.00%> (ø)

... and 1050 files with indirect coverage changes

@keiya01 keiya01 changed the title feat(web): copy Icon component from classic. chore(web): copy Icon component from classic. May 31, 2023
@KaWaite KaWaite changed the title chore(web): copy Icon component from classic. chore(web): copy Icon component from classic Jun 1, 2023
長田淳史 and others added 2 commits June 1, 2023 13:27
atnagata and others added 3 commits June 1, 2023 14:39
@keiya01 keiya01 merged commit 9942876 into reearth:main Jun 1, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants