Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): refactor graphQL and set new standard #536

Merged
merged 58 commits into from
Jul 10, 2023
Merged

Conversation

pyshx
Copy link
Contributor

@pyshx pyshx commented Jun 29, 2023

Overview

This introduces fetcher function in the network layer of services, with changes made in reearth-beta features.

  • codegen.yml -> codegen.ts
  • GQL provider refactor
  • Setup services/api to abstract graphql query/mutations use more

@pyshx pyshx requested a review from KaWaite as a code owner June 29, 2023 08:16
@netlify
Copy link

netlify bot commented Jun 29, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit ee724ad
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64abb7454cf0830008c06417
😎 Deploy Preview https://deploy-preview-536--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Jun 29, 2023
@github-actions github-actions bot requested a review from nina992 June 29, 2023 08:16
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #536 (9a9760a) into main (45ec8f3) will increase coverage by 3.04%.
The diff coverage is 51.91%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
+ Coverage   25.60%   28.65%   +3.04%     
==========================================
  Files        1362     1376      +14     
  Lines      154647   149238    -5409     
  Branches     3559     3573      +14     
==========================================
+ Hits        39596    42762    +3166     
+ Misses     113899   105324    -8575     
  Partials     1152     1152              
Flag Coverage Δ
web 26.57% <51.91%> (+3.74%) ⬆️
web-beta 26.57% <51.91%> (+3.74%) ⬆️
web-classic 26.57% <51.91%> (+3.74%) ⬆️
web-utils 26.57% <51.91%> (+3.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/beta/components/Dropdown/index.tsx 0.00% <0.00%> (ø)
...beta/features/Navbar/Menus/WorkspaceMenu/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Navbar/hooks.ts 0.00% <0.00%> (ø)
web/src/beta/pages/Page.tsx 0.00% <0.00%> (ø)
web/src/services/api/types.ts 0.00% <0.00%> (ø)
web/src/services/gql/__gen__/graphql.ts 100.00% <ø> (ø)
web/src/services/gql/provider/pagination.ts 14.28% <14.28%> (ø)
web/src/services/gql/provider/index.tsx 16.92% <16.92%> (ø)
web/src/services/api/projectApi.ts 18.75% <18.75%> (ø)
web/src/services/gql/provider/links/errorLink.ts 23.07% <23.07%> (ø)
... and 17 more

... and 2 files with indirect coverage changes

@KaWaite KaWaite changed the title feat(web): fetcher functions intro chore(web): refactor graphQL and set new standard Jul 2, 2023
web/codegen.ts Show resolved Hide resolved
@KaWaite KaWaite merged commit a002e67 into main Jul 10, 2023
13 checks passed
@KaWaite KaWaite deleted the feat/fetcher-function branch July 10, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants