Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): add property update support to story blocks #629

Merged
merged 18 commits into from
Aug 23, 2023

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Aug 14, 2023

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@KaWaite KaWaite self-assigned this Aug 14, 2023
@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for reearth-web canceled.

Name Link
🔨 Latest commit 26e788d
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64e5fc9cb56be40008a20d8e

@github-actions github-actions bot added the web label Aug 14, 2023
@KaWaite KaWaite marked this pull request as ready for review August 23, 2023 06:56
@github-actions github-actions bot requested a review from nina992 August 23, 2023 06:57
@KaWaite KaWaite requested a review from keiya01 as a code owner August 23, 2023 07:01
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #629 (26e788d) into main (958a1ce) will increase coverage by 0.14%.
The diff coverage is 6.26%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
+ Coverage   27.95%   28.09%   +0.14%     
==========================================
  Files        1456     1483      +27     
  Lines      158676   160747    +2071     
  Branches     3733     3737       +4     
==========================================
+ Hits        44354    45164     +810     
- Misses     113232   114427    +1195     
- Partials     1090     1156      +66     
Flag Coverage Δ
web 26.07% <6.26%> (-0.04%) ⬇️
web-beta 26.07% <6.26%> (-0.04%) ⬇️
web-classic 26.07% <6.26%> (-0.04%) ⬇️
web-utils 26.07% <6.26%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...src/beta/components/fields/PropertyFields/hooks.ts 0.00% <0.00%> (ø)
...rc/beta/components/fields/PropertyFields/index.tsx 0.00% <0.00%> (ø)
...beta/features/Editor/StoryPanel/Block/Template.tsx 0.00% <0.00%> (ø)
...es/Editor/StoryPanel/Block/builtin/Image/index.tsx 0.00% <0.00%> (ø)
...res/Editor/StoryPanel/Block/builtin/Text/index.tsx 0.00% <0.00%> (ø)
...oryPanel/Block/builtin/common/ActionPanel/hooks.ts 0.00% <ø> (ø)
...ryPanel/Block/builtin/common/ActionPanel/index.tsx 0.00% <0.00%> (ø)
...Editor/StoryPanel/Block/builtin/common/Wrapper.tsx 0.00% <0.00%> (ø)
...tor/StoryPanel/Block/builtin/common/click-away.tsx 0.00% <0.00%> (ø)
...es/Editor/StoryPanel/Block/builtin/common/hooks.ts 0.00% <0.00%> (ø)
... and 11 more

... and 61 files with indirect coverage changes

@KaWaite KaWaite merged commit fdd4eeb into main Aug 23, 2023
17 checks passed
@KaWaite KaWaite deleted the chore/add-property-update-support-storyblocks branch August 23, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant