Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): limit lexical css #664

Merged
merged 1 commit into from
Sep 6, 2023
Merged

chore(web): limit lexical css #664

merged 1 commit into from
Sep 6, 2023

Conversation

airslice
Copy link
Contributor

@airslice airslice commented Sep 6, 2023

Overview

Add .lexical to lexical component to avoid style pollution.

Also move float link editor into editor DOM for better organization.

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@github-actions github-actions bot added the web label Sep 6, 2023
@airslice airslice marked this pull request as ready for review September 6, 2023 06:00
@netlify
Copy link

netlify bot commented Sep 6, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit ed8a7a3
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64f8158115178b00087bcf10
😎 Deploy Preview https://deploy-preview-664--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@airslice airslice changed the title refactor: limit lexical css chore(web): limit lexical css Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #664 (ed8a7a3) into main (f7fe7f6) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
- Coverage   26.94%   26.94%   -0.01%     
==========================================
  Files        1535     1535              
  Lines      167331   167336       +5     
  Branches     3862     3862              
==========================================
  Hits        45086    45086              
- Misses     121156   121161       +5     
  Partials     1089     1089              
Flag Coverage Δ
web 25.25% <0.00%> (-0.01%) ⬇️
web-beta 25.25% <0.00%> (-0.01%) ⬇️
web-classic 25.25% <0.00%> (-0.01%) ⬇️
web-utils 25.25% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/beta/lib/lexical/RichTextEditor/index.tsx 0.00% <0.00%> (ø)

@airslice airslice merged commit f015000 into main Sep 6, 2023
21 checks passed
@airslice airslice deleted the chore/limit-lexical-css branch September 6, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants