This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
fix: 1st bug hunt of october #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Deploy Preview for reearth-web failed. 🔨 Explore the source changes: ff9cc36 🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/6163f87083ed03000884ecd6 |
Codecov Report
@@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage 53.43% 53.43%
=======================================
Files 48 48
Lines 889 889
Branches 117 117
=======================================
Hits 475 475
Misses 364 364
Partials 50 50 |
HideBa
reviewed
Oct 12, 2021
issmail-basel
approved these changes
Oct 12, 2021
HideBa
approved these changes
Oct 12, 2021
keiya01
pushed a commit
that referenced
this pull request
Apr 25, 2023
* Add infobox padding * infobox and text block padding * fix titles and descriptions * update textBlock padding IDs * add Japanese translation Co-authored-by: basel.issmail <basel.issmail@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I've done
What I haven't done
Can't test add member bug on local env since there is only one user
Which point I want you to review particularly
Let me know if the add member fix doesn't seem like it'll work/change anything! Since I can't test it would like other opinions. Anyways, pretty certain it won't break anything.