This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
fix: layers disappearing when in nested folders #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Deploy Preview for reearth-web failed. 🔨 Explore the source changes: 183d30e 🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/61668f82d0724f00087c9e04 |
Codecov Report
@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 53.43% 53.53% +0.10%
==========================================
Files 48 48
Lines 889 891 +2
Branches 117 119 +2
==========================================
+ Hits 475 477 +2
Misses 364 364
Partials 50 50
|
HideBa
previously approved these changes
Oct 13, 2021
issmail-basel
approved these changes
Oct 13, 2021
keiya01
pushed a commit
that referenced
this pull request
Apr 25, 2023
* remove schema field from property.SchemaGroup and Item * rename methods * delete property.FieldUnsafeBuilder * add methods to value * refactor test * refactor usage of references and Clone methods * add cast method to property.Field * add RemoveLayer method to layer/IDList * add IDs and Properties methods to layer/List * rename property/GroupList.GetGroup * fix test * add IDs method to property/List * add nil check to property/SchemaField and plugin/Plugin * add SchemaLoaderFromMap to property * add PropertySchema method to manifest/Manifest
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where all markers inside a nested folder (folder within a folder, or deeper) stopped displaying on cesium.
Also affected was marker information in Storytelling. Storytelling showed blanks which were broken (if selected nothing would happen, or if cycling through the layers, would break the flow and be completely back to 0)