This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
fix: password policy conversion in config #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for reearth-web ready! 🔨 Explore the source changes: 59e4126 🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/617a2132115aae00084ca63d 😎 Browse the preview: https://deploy-preview-113--reearth-web.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #113 +/- ##
==========================================
+ Coverage 44.71% 44.81% +0.10%
==========================================
Files 55 56 +1
Lines 1087 1100 +13
Branches 170 174 +4
==========================================
+ Hits 486 493 +7
- Misses 549 554 +5
- Partials 52 53 +1
|
added 2 commits
October 28, 2021 11:29
rot1024
suggested changes
Oct 28, 2021
rot1024
previously approved these changes
Oct 28, 2021
rot1024
changed the title
rot1024
approved these changes
Oct 28, 2021
keiya01
pushed a commit
that referenced
this pull request
Apr 25, 2023
…tic property migration) (#113)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem in how the config file's password policy is converted from string to RegExp. Helped by @rot1024