This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
feat: tagging of layers #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for reearth-web ready! 🔨 Explore the source changes: f37b314 🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/61bc2cf19e363a000713ea0b 😎 Browse the preview: https://deploy-preview-144--reearth-web.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #144 +/- ##
==========================================
+ Coverage 44.22% 45.48% +1.25%
==========================================
Files 56 60 +4
Lines 1135 1284 +149
Branches 179 205 +26
==========================================
+ Hits 502 584 +82
- Misses 580 641 +61
- Partials 53 59 +6
|
rot1024
approved these changes
Dec 17, 2021
Co-authored-by: rot1024 <aayhrot@gmail.com>
Co-authored-by: rot1024 <aayhrot@gmail.com>
|
works good for me |
KaWaite
reviewed
Dec 17, 2021
Co-authored-by: KaWaite <34051327+KaWaite@users.noreply.github.com>
KaWaite
reviewed
Dec 17, 2021
Co-authored-by: KaWaite <34051327+KaWaite@users.noreply.github.com>
KaWaite
reviewed
Dec 17, 2021
KaWaite
reviewed
Dec 17, 2021
KaWaite
reviewed
Dec 17, 2021
Co-authored-by: KaWaite <34051327+KaWaite@users.noreply.github.com>
KaWaite
reviewed
Dec 17, 2021
There was a problem hiding this comment.
Sorry I guess I don't have time to go through the code fully. But Inoue-san approved and you'll refactor next week so I'll go through more thoroughly then.
A couple things though from testing it out:
- There is a bug in the right panel's tabs. If you select Export or Tag, and then try to select something else, it'll go back to the layer tag
- the default tag group's name should be uppercased (default -> Default) (I also am not sure calling it Default is very nice, but we can discuss that later)
- There is ZERO indication of what each input does in the tag tab. It just says "default" and then has two separated inputs. If you can add placeholders like in @lavalse 's design ("Add a tag" and "Add a tag group")
Also, the PR is failing right now
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The developed tag system excludes the tag widget.
Users can create, delete, attach and detach tags.
What I've done
What I haven't done
Screenshot
Which point I want you to review particularly
Memo
tag panecomponent couldn't be a reusable component.Next year, I'll refactor the source code. If there isn't a critical problem plz approve.