Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: photooverlay transition does not work in Android #154

Merged
merged 1 commit into from Dec 23, 2021
Merged

Conversation

HideBa
Copy link
Member

@HideBa HideBa commented Dec 23, 2021

Overview

What I've done

What I haven't done

How I tested

Screenshot

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Dec 23, 2021

✔️ Deploy Preview for reearth-web ready!

🔨 Explore the source changes: a49216a

🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/61c3d9e1df3fde00082a1a60

😎 Browse the preview: https://deploy-preview-154--reearth-web.netlify.app

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #154 (a49216a) into main (8d06fa2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   45.48%   45.48%           
=======================================
  Files          60       60           
  Lines        1284     1284           
  Branches      205      205           
=======================================
  Hits          584      584           
  Misses        641      641           
  Partials       59       59           

@HideBa HideBa marked this pull request as ready for review December 23, 2021 02:18
@rot1024 rot1024 changed the title fix: photooverlay transition fix: photooverlay transition in Android Dec 23, 2021
@rot1024 rot1024 changed the title fix: photooverlay transition in Android fix: photooverlay transition does not work in Android Dec 23, 2021
@HideBa HideBa merged commit decbfe1 into main Dec 23, 2021
@HideBa HideBa deleted the fix-photooverlay branch December 23, 2021 03:44
keiya01 added a commit that referenced this pull request Apr 25, 2023
)

* feat: impl totalCount resolver to count dataset

* chore: run `go generate`

* Update internal/infrastructure/memory/dataset.go

Co-authored-by: rot1024 <aayhrot@gmail.com>

* Update internal/infrastructure/mongo/dataset.go

Co-authored-by: rot1024 <aayhrot@gmail.com>

Co-authored-by: rot1024 <aayhrot@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants