Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: plugin blocks cannot be deleted #164

Merged
merged 2 commits into from Jan 31, 2022
Merged

Conversation

issmail-basel
Copy link
Contributor

Overview

Deleting custom blocks

What I've done

  • Removed name checking condition

What I haven't done

  • Did not add any features

How I tested

  • Create custom block
  • Delete custom blocks
  • Delete infobox
  • Delete builtin blocks

Which point I want you to review particularly

  • Code change

@netlify
Copy link

netlify bot commented Jan 26, 2022

✔️ Deploy Preview for reearth-web ready!

🔨 Explore the source changes: f303d72

🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/61f7898023c001000849579e

😎 Browse the preview: https://deploy-preview-164--reearth-web.netlify.app

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #164 (f303d72) into main (2643c77) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   45.39%   45.39%           
=======================================
  Files          60       60           
  Lines        1302     1302           
  Branches      207      207           
=======================================
  Hits          591      591           
  Misses        652      652           
  Partials       59       59           

@rot1024 rot1024 changed the title fix: custom blocks cannot be deleted fix: plugin blocks cannot be deleted Jan 28, 2022
@issmail-basel issmail-basel merged commit a4f17f7 into main Jan 31, 2022
@issmail-basel issmail-basel deleted the fix-deleting-custom-blocks branch January 31, 2022 07:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants