This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
fix: button widget squishing its text & infobox mask click away #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for reearth-web ready! 🔨 Explore the source changes: f23be8b 🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/62280792dd39d700087407cc 😎 Browse the preview: https://deploy-preview-185--reearth-web.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #185 +/- ##
=======================================
Coverage 44.74% 44.74%
=======================================
Files 60 60
Lines 1323 1323
Branches 215 215
=======================================
Hits 592 592
Misses 669 669
Partials 62 62 |
KaWaite
changed the title
rot1024
suggested changes
Mar 8, 2022
Co-authored-by: rot1024 <aayhrot@gmail.com>
…h-web into fix/button-widget
rot1024
changed the title
rot1024
approved these changes
Mar 8, 2022
|
works quite nice for me . Thank you @KaWaite |
HideBa
approved these changes
Mar 9, 2022
Co-authored-by: HideBa <49897538+HideBa@users.noreply.github.com>
Co-authored-by: HideBa <49897538+HideBa@users.noreply.github.com>
Co-authored-by: HideBa <49897538+HideBa@users.noreply.github.com>
Co-authored-by: HideBa <49897538+HideBa@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Had problem with the text inside button widgets gettings squished when width of viewer wasn't wide enough to safely contain multiple widgets side by side.
What I've done
Updated the widget align system so that it will wrap its widgets if not enough space. This created a little issue with the Button widgets, so needed to update their min-sizes.
Also, as requested by @lavalse I have made it so the text inside the Button's dropdown menu won't wrap, which was especially undesirable with non-English scripts like Chinese characters.