Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

chore: introduce i18next #212

Merged
merged 14 commits into from Apr 27, 2022
Merged

chore: introduce i18next #212

merged 14 commits into from Apr 27, 2022

Conversation

rot1024
Copy link
Member

@rot1024 rot1024 commented Apr 26, 2022

Overview

What I've done

  • Introduce i18nnext
  • Add a npm script: yarn i18n (so fast!!!)
  • Rename gen:18n script to i18n:legacy
  • Rename gen:gql script to gql (fewer type times)

What I haven't done

react-intl is not uninstalled yet. The number of translations is so large that it would be difficult to migrate them all at once, so we would like to rewrite them using i18next when we see react-intl when we revamp a component.

How I tested

Check Netlify preview to confrim the app continues to work

@rot1024 rot1024 requested a review from KaWaite as a code owner April 26, 2022 09:19
@netlify
Copy link

netlify bot commented Apr 26, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 9ad251e
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/62691b50f693ff00097bf605
😎 Deploy Preview https://deploy-preview-212--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #212 (9ad251e) into main (9a59938) will increase coverage by 0.26%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   43.70%   43.97%   +0.26%     
==========================================
  Files          60       63       +3     
  Lines        1350     1360      +10     
  Branches      227      228       +1     
==========================================
+ Hits          590      598       +8     
- Misses        698      699       +1     
- Partials       62       63       +1     
Impacted Files Coverage Δ
src/i18n/legacy/locale.ts 85.71% <ø> (ø)
src/i18n/legacy/provider.tsx 75.00% <ø> (ø)
src/i18n/legacy/publishedProvider.tsx 50.00% <ø> (ø)
src/i18n/publishedProvider.tsx 0.00% <0.00%> (ø)
src/test/utils.tsx 100.00% <ø> (ø)
src/i18n/provider.tsx 83.33% <83.33%> (ø)
src/i18n/i18n.ts 100.00% <100.00%> (ø)

.vscode/settings.json Outdated Show resolved Hide resolved
i18next-parser.config.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/translations/en.yml Outdated Show resolved Hide resolved
src/i18n/provider.tsx Outdated Show resolved Hide resolved
src/i18n/provider.tsx Outdated Show resolved Hide resolved
Copy link
Member

@KaWaite KaWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed!

@rot1024 rot1024 enabled auto-merge (squash) April 27, 2022 04:55
Copy link
Member

@KaWaite KaWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rot1024 rot1024 merged commit 0ac0c2d into main Apr 27, 2022
@rot1024 rot1024 deleted the i18next branch April 27, 2022 10:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants