This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
chore: introduce i18next #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #212 +/- ##
==========================================
+ Coverage 43.70% 43.97% +0.26%
==========================================
Files 60 63 +3
Lines 1350 1360 +10
Branches 227 228 +1
==========================================
+ Hits 590 598 +8
- Misses 698 699 +1
- Partials 62 63 +1
|
KaWaite
reviewed
Apr 27, 2022
KaWaite
reviewed
Apr 27, 2022
KaWaite
reviewed
Apr 27, 2022
KaWaite
reviewed
Apr 27, 2022
KaWaite
reviewed
Apr 27, 2022
KaWaite
reviewed
Apr 27, 2022
KaWaite
reviewed
Apr 27, 2022
KaWaite
reviewed
Apr 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed!
KaWaite
approved these changes
Apr 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What I've done
yarn i18n
(so fast!!!)gen:18n
script toi18n:legacy
gen:gql
script togql
(fewer type times)What I haven't done
react-intl is not uninstalled yet. The number of translations is so large that it would be difficult to migrate them all at once, so we would like to rewrite them using i18next when we see react-intl when we revamp a component.
How I tested
Check Netlify preview to confrim the app continues to work