This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
feat: change layer indicators from preset list #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #245 +/- ##
=======================================
Coverage 51.33% 51.33%
=======================================
Files 56 56
Lines 1165 1165
Branches 182 182
=======================================
Hits 598 598
Misses 505 505
Partials 62 62 |
added 2 commits
June 13, 2022 16:09
…dicators-change-styles
rot1024
suggested changes
Jun 14, 2022
KaWaite
reviewed
Jun 14, 2022
src/components/molecules/Visualizer/Engine/Cesium/core/Indicator.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Jun 14, 2022
src/components/molecules/Visualizer/Engine/Cesium/core/Indicator.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Jun 14, 2022
src/components/molecules/Visualizer/Engine/Cesium/core/Indicator.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Jun 14, 2022
src/components/molecules/Visualizer/Engine/Cesium/core/Indicator.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Jun 14, 2022
src/components/molecules/Visualizer/Engine/Cesium/core/Indicator.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Jun 14, 2022
src/components/molecules/Visualizer/Engine/Cesium/core/Indicator.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Jun 14, 2022
src/components/molecules/Visualizer/Engine/Cesium/core/Indicator.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Jun 14, 2022
KaWaite
reviewed
Jun 14, 2022
KaWaite
reviewed
Jun 14, 2022
src/components/molecules/Visualizer/Engine/Cesium/core/Indicator.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Jun 14, 2022
There was a problem hiding this comment.
A few comments.
Also, is there any chance we will support changing the color of the crosshair indicator? @lavalse maybe can shed some light on that. Currently the svg is setup to only be white, but would be pretty simple to allow for color.
…dicators-change-styles
…/reearth-web into indicators-change-styles
…or.tsx Co-authored-by: KaWaite <34051327+KaWaite@users.noreply.github.com>
Co-authored-by: KaWaite <34051327+KaWaite@users.noreply.github.com>
…or.tsx Co-authored-by: KaWaite <34051327+KaWaite@users.noreply.github.com>
…or.tsx Co-authored-by: KaWaite <34051327+KaWaite@users.noreply.github.com>
KaWaite
reviewed
Jun 16, 2022
KaWaite
reviewed
Jun 16, 2022
added 2 commits
June 17, 2022 16:44
…dicators-change-styles
KaWaite
reviewed
Jun 22, 2022
…dicators-change-styles
|
Sorry for testing a little bit late. But I found some problems maybe more importent then animation. 😄
|
added 4 commits
June 27, 2022 15:24
rot1024
approved these changes
Jul 4, 2022
…dicators-change-styles
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Layer selecting indicator: is an indicator appears when user select a layer.
We created preset list of indicators that user can choose one of them when selecting a layer.
What I've done
Design a preset list of indicators for layer selecting.
Add indicator section in scene right tab and give the user the ability to choose among them.
Give the user the ability to upload his own indicator.
What I haven't done
How I tested
Screenshot
Which point I want you to review particularly
Memo
Design link : https://www.figma.com/file/bdnfDaGXGoNfUws4y7JItl/Re%3AEarth-UI-Gamma?node-id=10319%3A174052
Backend PR: reearth/reearth-backend#158