feat: add delete assets confirm modal and fix bugs #25

lavalse · 2021-07-08T03:09:41Z

Overview

What I've done

add a delete assets modal in assets setting page
fix project page no data bug
fix no create new asset bug

What I haven't done

How I tested

Which point I want you to review particularly

Thanks

@Basel-Issmail @KaWaite

codecov · 2021-07-08T03:11:56Z

Codecov Report

Merging #25 (8cbee37) into main (d06ee7e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   52.25%   52.25%           
=======================================
  Files          45       45           
  Lines         643      643           
  Branches      125      125           
=======================================
  Hits          336      336           
  Misses        232      232           
  Partials       75       75

src/components/molecules/Settings/Workspace/Asset/AssetDeleteModal/index.tsx

src/components/organisms/Dashboard/hooks.ts

src/components/organisms/Settings/ProjectList/hooks.ts

KaWaite

Please check the couple comments!

issmail-basel

Seems good

lavalse added 3 commits July 5, 2021 17:43

init branch

eecafcc

add the assets delete confirm modal

f355cde

fix no image upload bug and no project data bug

af9e714

lavalse changed the title ~~Add delete assets confirm modal~~ feat: add delete assets confirm modal and fix bugs Jul 8, 2021

lavalse added 3 commits July 8, 2021 12:32

clean files and fix dashboard project no data bug

f3dcff3

fix can't use project thumbnail bug

c6afbc9

fix with bassel's code

daf2a14

lavalse marked this pull request as ready for review July 8, 2021 04:45

lavalse requested review from KaWaite, HideBa, rot1024 and issmail-basel July 8, 2021 04:45

lavalse self-assigned this Jul 8, 2021