Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: dataset page showing errors on page refreshing #253

Merged
merged 1 commit into from Jun 20, 2022
Merged

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Jun 20, 2022

Overview

On setting page/dataset, if refresh page, a warning appears

What I've done

skip the undefined or empty scene id when fetching the dataset list

What I haven't done

How I tested

Screenshot

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Jun 20, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit deb6b95
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/62b04b7a5767ef00081b91e9
😎 Deploy Preview https://deploy-preview-253--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #253 (deb6b95) into main (b0e8e67) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   51.33%   51.33%           
=======================================
  Files          56       56           
  Lines        1165     1165           
  Branches      182      182           
=======================================
  Hits          598      598           
  Misses        505      505           
  Partials       62       62           

@nina992 nina992 marked this pull request as ready for review June 20, 2022 10:53
@nina992 nina992 requested a review from KaWaite as a code owner June 20, 2022 10:53
@rot1024 rot1024 changed the title fix: fix dataset page showing warning on page refreshing fix: dataset page showing errors on page refreshing Jun 20, 2022
@rot1024 rot1024 merged commit 77a3ced into main Jun 20, 2022
@rot1024 rot1024 deleted the fix/dataset-Page branch June 20, 2022 11:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants