This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
fix: auto fetch more items in dashboard page , project list , dataset page for big screens #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
nina992
changed the title
Codecov Report
@@ Coverage Diff @@
## main #255 +/- ##
=======================================
Coverage 51.33% 51.33%
=======================================
Files 56 56
Lines 1165 1165
Branches 182 182
=======================================
Hits 598 598
Misses 505 505
Partials 62 62 |
KaWaite
reviewed
Jun 27, 2022
src/components/molecules/Common/AssetModal/AssetContainer/index.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Jun 27, 2022
KaWaite
reviewed
Jun 27, 2022
KaWaite
reviewed
Jun 27, 2022
src/components/molecules/Common/AssetModal/AssetContainer/index.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: KaWaite <34051327+KaWaite@users.noreply.github.com>
…x.tsx Co-authored-by: KaWaite <34051327+KaWaite@users.noreply.github.com>
…x.tsx Co-authored-by: KaWaite <34051327+KaWaite@users.noreply.github.com>
…finit-scroll-dashboard
KaWaite
reviewed
Jun 28, 2022
KaWaite
reviewed
Jun 28, 2022
Co-authored-by: KaWaite <34051327+KaWaite@users.noreply.github.com>
Co-authored-by: KaWaite <34051327+KaWaite@users.noreply.github.com>
added 3 commits
June 30, 2022 23:18
…finit-scroll-dashboard
…/reearth-web into infinit-scroll-dashboard
KaWaite
approved these changes
Jul 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
After adding infinite scroll and for big monitors the page only shows limit number of items and the scroll bar didn't appear so the system didn't fetch all items related to this list.
What I've done
fix this and auto fetch the items when the page is too large
What I haven't done
How I tested
Screenshot
Which point I want you to review particularly
Memo