Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: asset modal flushes when camera limiter is enabled #261

Merged
merged 2 commits into from Jun 30, 2022

Conversation

rot1024
Copy link
Member

@rot1024 rot1024 commented Jun 30, 2022

Fixed a bug where enabling the camera limiter would start an infinite render loop and prevent the selection of assets in the asset modal.

@rot1024 rot1024 requested a review from KaWaite as a code owner June 30, 2022 05:18
@netlify
Copy link

netlify bot commented Jun 30, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 8e841fc
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/62bd322fbcf5210008f808a0
😎 Deploy Preview https://deploy-preview-261--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #261 (8e841fc) into main (85abadb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   51.33%   51.33%           
=======================================
  Files          56       56           
  Lines        1165     1165           
  Branches      182      182           
=======================================
  Hits          598      598           
  Misses        505      505           
  Partials       62       62           

@rot1024 rot1024 merged commit fd46316 into main Jun 30, 2022
@rot1024 rot1024 deleted the fix-asset-modal-refreshing branch June 30, 2022 05:25
rot1024 added a commit that referenced this pull request Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant