Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: pointer events issues around widgets #279

Merged
merged 4 commits into from Jul 21, 2022
Merged

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Jul 21, 2022

What I've done

fixed:

  • Not being able to scroll beside smaller widgets when a bigger widget is in the same GridArea
  • Being able to use widgets (ie. click on buttons) while in WAS editor mode. If you can resize, the overlay disappeared, and then you could use the widget. Now, no pointerEvents happen inside Widgets when in WAS editor mode.

How I tested

  • Manually tested all builtin widgets, as well as a plugin widget.

@KaWaite KaWaite requested a review from rot1024 as a code owner July 21, 2022 02:33
@KaWaite KaWaite self-assigned this Jul 21, 2022
@netlify
Copy link

netlify bot commented Jul 21, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit abd91da
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/62d8fffd685cf200080485bb
😎 Deploy Preview https://deploy-preview-279--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rot1024 rot1024 changed the title fix: pointer events issues around Widgets fix: pointer events issues around widgets Jul 21, 2022
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #279 (abd91da) into main (48de868) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #279   +/-   ##
=====================================
  Coverage   6.12%   6.12%           
=====================================
  Files        439     439           
  Lines       8801    8797    -4     
  Branches    2242    2240    -2     
=====================================
  Hits         539     539           
+ Misses      8185    8181    -4     
  Partials      77      77           
Impacted Files Coverage Δ
...molecules/Visualizer/Widget/Storytelling/index.tsx 0.00% <0.00%> (ø)
...c/components/molecules/Visualizer/Widget/index.tsx 0.00% <0.00%> (ø)
...ts/molecules/Visualizer/WidgetAlignSystem/Area.tsx 0.00% <ø> (ø)
...ecules/Visualizer/WidgetAlignSystem/MobileZone.tsx 0.00% <ø> (ø)
...ts/molecules/Visualizer/WidgetAlignSystem/Zone.tsx 0.00% <ø> (ø)
...s/molecules/Visualizer/WidgetAlignSystem/index.tsx 0.00% <ø> (ø)

@KaWaite KaWaite merged commit 219ea4b into main Jul 21, 2022
@KaWaite KaWaite deleted the fix-widget-zoom-area branch July 21, 2022 07:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants