This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #280 +/- ##
==========================================
+ Coverage 11.33% 14.32% +2.98%
==========================================
Files 480 481 +1
Lines 45674 46135 +461
Branches 384 391 +7
==========================================
+ Hits 5178 6607 +1429
+ Misses 40482 39514 -968
Partials 14 14
|
rot1024
suggested changes
Jul 22, 2022
KaWaite
reviewed
Jul 29, 2022
KaWaite
reviewed
Jul 29, 2022
rot1024
changed the title
feat: add mouse event api
feat: add mouse events to plugin API
Aug 1, 2022
rot1024
approved these changes
Aug 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close reearth/reearth#299
close reearth/reearth#298
Overview
This feature extends plugin API event with multiple mouse events:
Events:
On mouse keys:
On mouse behavior:
On mouse wheel:
Also conatins:
Event Props:
{ delta: number; }
{ x?: number; y?: number; lat?: number; lng?: number; height?: number; layerId?: string; }
The implementation for engine
cesium
is base onresium
Viewer
events.What I've done
cesium
by usingresium
events.providerProps
.emit
.What I haven't done
Known issue:
off
doesn't work well when calling from plugin. It might be related with quickjs and will not be handled in this PR.How I tested
Screenshot
Which point I want you to review particularly
Known issue:
resium
Viewer
events is somehow tortuous and the code added in engineRef also got some affected. I use a middle variablemouseEventCallbacks
to store the callbacks and export it in order to pass it to resiumViewer
component. This will perhaps lead to some problem when we add other engines in the future (not much maybe).emit
to events) will lead to some perfermance waste (but not much).Memo