Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

feat: add overlay warning to earth editor if browser width is too narrow #304

Merged
merged 6 commits into from Aug 29, 2022

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Aug 26, 2022

Overview

What I've done

What I haven't done

How I tested

Screenshot

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Aug 26, 2022

Deploy Preview for reearth-web failed.

Name Link
🔨 Latest commit 41490b5
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/630c060616154200085c6fb0

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #304 (f5ed32a) into main (f774ee5) will decrease coverage by 0.19%.
The diff coverage is 2.38%.

❗ Current head f5ed32a differs from pull request most recent head 41490b5. Consider uploading reports for the commit 41490b5 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
- Coverage   16.42%   16.23%   -0.20%     
==========================================
  Files         493      493              
  Lines       48075    47604     -471     
  Branches      520      515       -5     
==========================================
- Hits         7898     7730     -168     
+ Misses      40160    39857     -303     
  Partials       17       17              
Impacted Files Coverage Δ
src/components/atoms/Overlay/index.tsx 0.00% <0.00%> (ø)
src/components/atoms/OverlayWithMessage/index.tsx 0.00% <0.00%> (ø)
...nts/molecules/Common/BrowserWidthWarning/index.tsx 0.00% <0.00%> (ø)
src/components/pages/EarthEditor/index.tsx 0.00% <0.00%> (ø)
src/components/atoms/Icon/icons.ts 100.00% <100.00%> (ø)
...nents/molecules/Visualizer/Engine/Cesium/common.ts 21.50% <0.00%> (-8.89%) ⬇️
src/components/atoms/Timeline/hooks.ts 90.26% <0.00%> (-1.12%) ⬇️
...molecules/Visualizer/Engine/Cesium/useEngineRef.ts 65.43% <0.00%> (-0.64%) ⬇️
src/state/index.ts 89.28% <0.00%> (-0.49%) ⬇️
src/components/atoms/Timeline/index.test.tsx 98.77% <0.00%> (-0.11%) ⬇️
... and 22 more

Copy link
Member

@HideBa HideBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added translation

src/i18n/translations/ja.yml Outdated Show resolved Hide resolved
KaWaite and others added 2 commits August 29, 2022 09:18
Co-authored-by: HideBa <49897538+HideBa@users.noreply.github.com>
@KaWaite KaWaite enabled auto-merge (squash) August 29, 2022 00:20
@KaWaite KaWaite merged commit 7f5f917 into main Aug 29, 2022
@KaWaite KaWaite deleted the feat/add-min-width-overlay branch August 29, 2022 00:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants