This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
feat: extend plugin API with camera control #311
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
==========================================
+ Coverage 16.75% 17.07% +0.32%
==========================================
Files 502 502
Lines 48751 49273 +522
Branches 524 550 +26
==========================================
+ Hits 8168 8415 +247
- Misses 40565 40840 +275
Partials 18 18
|
airslice
changed the title
feat: extend plugin API of camera
feat: extend plugin API with camera control
Sep 12, 2022
rot1024
suggested changes
Sep 12, 2022
src/components/molecules/Visualizer/Engine/Cesium/useEngineRef.test.tsx
Outdated
Show resolved
Hide resolved
rot1024
approved these changes
Sep 14, 2022
KaWaite
approved these changes
Sep 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is required for reearth/reearth#337
This PR extends plugin API with:
What I've done
Implement these metheds on engine and expose them to plugin API.
What I haven't done
How I tested
Screenshot
Which point I want you to review particularly
enableScreenSpaceController
anddisableScreenSpaceController
seems too long but i didn't come out with any better naming for it.lookXxx
andmoveXxx
methods also can be merged into one with another param to define the direction but it will lead to one more condition check in each call and i think it might be better to provide these metheds more directly like this. Is that okey?Memo