Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: cannot input camera altitude less than 500 with camera pane #339

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

airslice
Copy link
Contributor

@airslice airslice commented Oct 28, 2022

Overview

There are two ways to set the camera position & pose with CameraField:

  1. Use map to get the position & pose you want and do capture.
  2. Input the exact value of camera properties.

We can set camera altitude less than 500 with 1, but when using 2 there's a hard coded minimum value as 500 which seems unnecessary.
Also since we recently support enter the earth's surface feature i think we can remove the minimum limit.

What I've done

  • Removed the minimum value limit on update altitude.

What I haven't done

How I tested

Set the camera with input.

Screenshot

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Oct 28, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit fd675cc
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/635f24b7b8868a0008dfa714
😎 Deploy Preview https://deploy-preview-339--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #339 (fd675cc) into main (7dd2b35) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #339   +/-   ##
=======================================
  Coverage   18.12%   18.12%           
=======================================
  Files         512      512           
  Lines       50921    50921           
  Branches      619      619           
=======================================
  Hits         9231     9231           
  Misses      41669    41669           
  Partials       21       21           
Impacted Files Coverage Δ
...or/PropertyPane/PropertyField/CameraField/hooks.ts 0.00% <0.00%> (ø)
...r/PropertyPane/PropertyField/CameraField/index.tsx 0.00% <0.00%> (ø)

@airslice airslice marked this pull request as ready for review October 28, 2022 02:13
@airslice airslice changed the title fix: cannot set camera altitude less than 500 with input component fix: cannot input camera altitude less than 500 with camera pane Oct 28, 2022
@airslice airslice merged commit 76a1696 into main Oct 31, 2022
@airslice airslice deleted the fix/camera-input-height-minimun-value branch October 31, 2022 01:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants