This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
feat: support acquiring locations with terrain #343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Mouse events want to get the correct location when terrain is on.
What I've done
Update the common
getLocationFromScreenXY
function, added a propwithTerrain
default asfalse
.If
withTerrain
istrue
it will useglobe.pick
instead ofcamera.pickEllipsoid
so that terrain can take effect. And if doesn't get the location it will still trycamera.pickEllipsoid
as a polyfill.What I haven't done
How I tested
Tested with plugin using mouse event.
Screenshot
Which point I want you to review particularly
Memo