Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: alignment issues in Widget Align System #344

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Oct 31, 2022

Overview

Placement of widgets were incorrect in a couple grid areas.
Needed to upgrade react-align since there were issues in that package.
Also updated on this end some logic errors.

@KaWaite KaWaite requested a review from rot1024 as a code owner October 31, 2022 09:00
@netlify
Copy link

netlify bot commented Oct 31, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 17851b3
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/635f8ebde4ac9800084973b3
😎 Deploy Preview https://deploy-preview-344--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #344 (17851b3) into main (f40d022) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
- Coverage   18.12%   18.12%   -0.01%     
==========================================
  Files         512      512              
  Lines       50937    50945       +8     
  Branches      619      619              
==========================================
  Hits         9232     9232              
- Misses      41684    41692       +8     
  Partials       21       21              
Impacted Files Coverage Δ
...ts/molecules/Visualizer/WidgetAlignSystem/Area.tsx 0.00% <0.00%> (ø)

Copy link
Contributor

@airslice airslice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The align logic seems a little complex and i think i only kind of understand it. I asked red to help test some and everything seems working good!

@KaWaite KaWaite merged commit 0e12ea6 into main Nov 1, 2022
@KaWaite KaWaite deleted the fix/was-alignment branch November 1, 2022 05:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants