This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
feat: extend plugin API supports move widget #346
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
airslice
changed the title
feat: plugin api set widget position
feat: extend plugin API supports set widget position
Nov 4, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
==========================================
- Coverage 18.39% 18.35% -0.05%
==========================================
Files 514 515 +1
Lines 51644 51781 +137
Branches 640 640
==========================================
+ Hits 9498 9502 +4
- Misses 42111 42244 +133
Partials 35 35
|
airslice
commented
Nov 25, 2022
rot1024
suggested changes
Nov 25, 2022
rot1024
reviewed
Nov 25, 2022
rot1024
approved these changes
Nov 25, 2022
KaWaite
reviewed
Nov 25, 2022
KaWaite
reviewed
Nov 25, 2022
KaWaite
approved these changes
Nov 25, 2022
airslice
changed the title
feat: extend plugin API supports set widget position
feat: extend plugin API supports move widget
Nov 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close reearth/reearth#364
Overview
Enable plugin set its widget position in widget align system.
Widget will get reload after set position.
What I've done
Implement plugin API:
What I haven't done
How I tested
Test with plugin:
Screenshot
Which point I want you to review particularly
Memo